Skip to content

feat(generativeai): Add compute token feature #12600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

feat(generativeai): Add compute token feature #12600

wants to merge 2 commits into from

Conversation

msampathkumar
Copy link
Member

@msampathkumar msampathkumar commented Sep 17, 2024 •
edited
Loading

Description

Fixes b358102024

To include the latest changes from main branch, I have raised a fresh PR @ #12638

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 17, 2024
@msampathkumar
Copy link
Member Author

Update: When I used SDK @ google-cloud-aiplatform[tokenization] @ git+https://github.com/googleapis/python-aiplatform.git the following errors don't come up. I will wait for the pkg to be released.

TypeError: Tokenizer.count_tokens() got an unexpected keyword argument 'system_instruction'

AttributeError: 'ComputeTokensResult' object has no attribute 'tokens_info'

@msampathkumar msampathkumar assigned Sita04 and gericdong and unassigned Sita04 Sep 26, 2024
@msampathkumar msampathkumar marked this pull request as ready for review September 26, 2024 19:22
@msampathkumar msampathkumar requested review from a team as code owners September 26, 2024 19:22
@msampathkumar msampathkumar added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 26, 2024
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Sep 26, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@gericdong gericdong

Labels

do not merge Indicates a pull request not ready for merge, due to either quality or timing. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msampathkumar @Sita04 @gericdong